Fix file paths in a couple tests #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 94.64% 94.74% +0.09%
==========================================
Files 28 27 -1
Lines 1102 1160 +58
==========================================
+ Hits 1043 1099 +56
- Misses 59 61 +2
Continue to review full report at Codecov.
|
|
Issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ropensci/software-review#233, fixes file paths in a few unit tests. I ran
devtools::test(),devtools::check(), anddevtools::check_built()(from the0_check.Rscript) and these all passed w/ no errors, warnings or notes.The oldrel build on Travis is failing because it cannot install the
XMLpackage, and never actually reaches the check stage. Apparentlytaxahas some dependency that itself depends onXML(based on the travis log, I think it'srentrez), and XML now requires R >= 4.0. I have no idea how to deal with this, except maybe specify an older version oftaxain the Description, or bump your minimum R version requirement and no longer support R < 4.0.Note that the file name for
Podocarpus_2020-01-10.rdais now hard-coded into the unit testtest-loadlast,R. If you make a newer version of this file, you'll need to modify the test accordingly I think.Let me know if you have any issues w/ this - I don't think using Eclipse will cause any issues w/ the new code, but I also haven't attempted to test it with a different IDE.