Populate Transitions in Transition Events (continuation) #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: SuperJappie08 <[email protected]>
Signed-off-by: SuperJappie08 <[email protected]>
SuperJappie08
added a commit
to SuperJappie08/rclcpp
that referenced
this pull request
Oct 15, 2025
Signed-off-by: SuperJappie08 <[email protected]>
SuperJappie08
added a commit
to SuperJappie08/rclpy
that referenced
this pull request
Oct 15, 2025
Signed-off-by: SuperJappie08 <[email protected]>
SuperJappie08
added a commit
to SuperJappie08/rclc
that referenced
this pull request
Oct 15, 2025
Signed-off-by: SuperJappie08 <[email protected]>
jmachowinski
approved these changes
Oct 15, 2025
fujitatomoya
approved these changes
Oct 20, 2025
|
Pulls: ros2/rcl_interfaces#185, #1269, ros2/rclcpp#2967, ros2/rclpy#1528
|
|
@fujitatomoya, this patch did not yet include compatibility with ros2/rcl_interfaces#185, but I have it (just not part of the PR yet) I will fix it now |
Adds compatibility with ros2/rcl_interfaces#185 Signed-off-by: SuperJappie08 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original author: @CursedRock17
Original reviewers: @fujitatomoya @audrow @ivanpauno @wjwwood
Continuation of #1140.
Implemented most feedback.
Fixes #1019
Is this user-facing behavior change?
Yes, Lifecycle transition events are now filled.
This comes with a small change in function signatures to support timestamping.
Did you use Generative AI?
No.
Additional Information
I would also recommend merging ros2/rcl_interfaces#185 to limit the amount of breaking changes.
I noticed that the
node_handlefield ofrcl_lifecycle_com_interface_tis never filled or used as far as I can see.