Fix handling completed job with expired result when work horse dies #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17d8e7c to
4a344b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2154 +/- ##
==========================================
- Coverage 93.61% 93.46% -0.16%
==========================================
Files 28 30 +2
Lines 3760 4114 +354
==========================================
+ Hits 3520 3845 +325
- Misses 240 269 +29 ☔ View full report in Codecov by Sentry. |
|
Here's the scenario as I understood it:
|
2 tasks
|
Mind adding a test for this? |
4a344b0 to
0975c00
Compare
|
@selwin After looking at it again, I was able to add a test demonstrating the issue. |
0975c00 to
1c7b3da
Compare
|
@fancyweb do you mind checking why the tests failed on Python 3.9? |
1c7b3da to
5e6baa9
Compare
5e6baa9 to
b82912d
Compare
|
Fixed in #2168 |
|
Thanks! |
|
Hello @selwin, could this be included in a new release plz? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2039,
Job.get_status()doesn't returnNonebut raisesInvalidJobOperationwhenrefresh=True.This change was not handled properly in
Worker.monitor_work_horse().I stumbled upon this with a use-case where a job with
result_ttl=0succeeds but the work horse doesn't exit with0(because it's wrapped).Job.get_status()ends up being called and raises an uncaught error.There's no existing test for the behavior and I wasn't able to produce one.