fix: Handle sentinel connection when using SpawnWorker #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using os.spawn to create a new worker, the sentinel connection is now properly recreated in the spawned process. Closes rq#2281
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
==========================================
- Coverage 93.61% 93.16% -0.46%
==========================================
Files 28 35 +7
Lines 3760 4623 +863
==========================================
+ Hits 3520 4307 +787
- Misses 240 316 +76 ☔ View full report in Codecov by Sentry. |
Collaborator
Would it be possible to do so reasonably easily in Github Actions? I think this would be necessary if we want Sentinel support to be stable in the long run. I also want the test coverage to be as high as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using os.spawn to create a new worker, the sentinel connection is now properly recreated in the spawned process.
Writing an integration test is quite hard. It would probably require us to setup and orchestrate a sentinel instance in the CI pipeline. Please give me a hint if you think this is necessary.
Closes #2281