Add TAG reader #164
Add TAG reader #164
Conversation
Some VTO device like IPC-HDW3441TM-AS have NFC Tag reader. With propose code add therse features
custom_components/dahua/__init__.py
Outdated
| asyncio.run_coroutine_threadsafe( | ||
| async_scan_tag(self.hass, card_id_md5, self.get_device_name()), self.hass.loop | ||
| ).result() | ||
| return |
There was a problem hiding this comment.
Are you certain this return needs to be here?
There was a problem hiding this comment.
Non necessary for the code execution. "return" avoid the code check again for event_key or listner,
reducing computational cost.
There was a problem hiding this comment.
I am not the owner of the PR, but I confirm that the code works once you remove the unneeded return, as you very well pointed out.
Shall we wait for @ozziii to fix it, or do you want me to do a separate PR?
|
Should we make a new PR for this? Think @ozziii abandoned this PR. Willing to make a new PR myself. |
|
@rroller could this be merged soon? This feature would be great. |
|
Hmm, there's a merge conflict, this needs to be fixed first, then i'll merge |
|
I created a new PR and merged it in #279 |
|
Released in 0.9.45 - https://github.com/rroller/dahua/releases/tag/0.9.45 |
Some VTO device like VTO2111D-P-S2 have NFC Tag reader.
With propose code add therse features