Generate machine ID using SHA-256 to avoid FIPS compliance issues #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While object ID generation doesn't rely on the cryptographic security of MD5, many FIPS environments block the use of MD5 entirely. Mongo has also moved away from MD5 in their implementations of object ID generation for the same reason [1]. They initially replaced MD5 with FNV-1a, but the C driver at least has since moved from FNV-1a to SipHash. In any case, the machine ID is generated only once during initialization in this code, so the speed of the chosen hash function is not important. [1] https://jira.mongodb.org/browse/DRIVERS-492
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While object ID generation doesn't rely on the cryptographic security of MD5, many FIPS environments block the use of MD5 entirely. Mongo has also moved away from MD5 in their implementations of object ID generation for the same reason [1]. They initially replaced MD5 with FNV-1a, but the C driver at least has since moved from FNV-1a to SipHash.
In any case, the machine ID is generated only once during initialization in this code, so the speed of the chosen hash function is not important.
[1] https://jira.mongodb.org/browse/DRIVERS-492