row_group_as_column = TRUE + 2 group variables#1801
Merged
rich-iannone merged 8 commits intorstudio:masterfrom Feb 28, 2025
Merged
row_group_as_column = TRUE + 2 group variables#1801rich-iannone merged 8 commits intorstudio:masterfrom
row_group_as_column = TRUE + 2 group variables#1801rich-iannone merged 8 commits intorstudio:masterfrom
Conversation
olivroy
commented
Jul 18, 2024
row_group_as_column = TRUE + 2 group variables
rich-iannone
approved these changes
Feb 28, 2025
Member
rich-iannone
left a comment
There was a problem hiding this comment.
This looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I tried a lot of things, but I am now missing a bit of context.
This fixes only the following case:
Related GitHub Issues and PRs
Relates to #2008
I ended up reverting the other commits because I am not getting it right.
for the original issue, it is a problem that the stub is not correctly initialized when
row_group_as_column = TRUE+ no row groups at the beginning.and
tab_row_group()doesn't behave wellChecklist
testthatunit tests totests/testthatfor any new functionality.