fix footnote marks in summary stub + footmark render in cells_stubhead() in opt_interactive() #1833
Merged
rich-iannone merged 3 commits intorstudio:masterfrom Aug 16, 2024
Merged
Conversation
tab_footnote() + fix some stylingtab_footnote() + fix some footnote rendering with cells_stubhead() in opt_interactive()
tab_footnote() + fix some footnote rendering with cells_stubhead() in opt_interactive() cells_stubhead() in opt_interactive()
…stub_grand_summary_rows()`
rich-iannone
approved these changes
Aug 16, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The footnote marks issue took me a while to figure out! Turns out it was a one-liner. Updating the reference to
"::rowname::"magically solved the issue!In a future PR, we could change this to
rowname_col_private.before
This PR
The tests are maybe wonky? I am just testing that we see a footnote mark in the table body. (before the footer)
For the stubhead issue, the problem was that html was FALSE before
It made footnote rendering bad:
Adding
html = TRUEtocolDef()fixes the issue!Related GitHub Issues and PRs
fix Footnote marks are not added to the summary stub with
cells_stub_grand_summary()#1832 (turns out this was a one line fix! (took me a while to figure out)Follow-up to Support
tab_style()+cells_stubhead()inopt_interactive()+ add visual test #1829Checklist
testthatunit tests totests/testthatfor any new functionality.