Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

yufree
Copy link
Contributor

@yufree yufree commented Nov 30, 2016

No description provided.

@@ -0,0 +1,70 @@
\documentclass[$col$]{ametsoc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of the pandoc includes in this template (e.g. include-header, include-before, include-after). Should these be added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's convenient!
I also add include-header into the ACS template.
Thanks!

change col into layout to make it clear
@jjallaire
Copy link
Member

There is also include-before and include-after, see: https://github.com/jgm/pandoc-templates/blob/master/default.latex#L231-L234

Could you also add this to the tests and ensure it passes on all platforms? (see https://github.com/rstudio/rticles/blob/master/tests/testthat/test_formats.R#L42-L48)

test_format("jss_article")
test_format("rjournal_article", file_check = FALSE)
test_format("acs_article", os_skip = "windows")
test_format("acs_article", file_check = FALSE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run fine in mac and Linux.
However, for windows I found tests failed and I set the file_check to false to pass tests both for acs and ams template. Such templates could be used in windows, just do not pass the unit tests. I think the reason would be the path of the figures generated by the templates.
The pnas template also can not pass the test right now and also could be used in windows. I think os_skip would work for it while file_check does not work.

% pandoc header
$for(header-includes)$
$header-includes$
$endfor$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These headers actually belong within the {document} around the $body$ (and perhaps other LaTeX that goes at the beginning or end). See https://github.com/jgm/pandoc-templates/blob/master/default.latex#L231-L272

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and I fixed it.

@jjallaire jjallaire merged commit 10a396d into rstudio:master Dec 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants