Make 'acl_public' settings to honor false values #793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly treat the 'acl_public' option in configuration file as a boolean. As the 'acl_public' option defaults to None, it wasn't treated as a boolean value and the conversion from string in configuration to boolean did not happen. Therefore the value from the configuration (eg. 'False') remained as a string and evaluated to true in boolean context.
Contributor
|
Issue should not be fixed in MASTER with another fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly treat the 'acl_public' option in configuration file as a
boolean.
As the 'acl_public' option defaults to None, it wasn't treated as a boolean
value and the conversion from string in configuration to boolean did not
happen. Therefore the value from the configuration (eg. 'False') remained
as a string and evaluated to true in boolean context.