Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Several fixes in IC3IA #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 14, 2020
Merged

Several fixes in IC3IA #119

merged 16 commits into from
Nov 14, 2020

Conversation

@makaimann
Copy link
Collaborator

This PR fixes a bug in the IC3IA backend and refactors so that we can run counterexample-guided prophecy:

  • term transfers from the interpolant solver were failing. The fixes include a change to the A, and B construction as well as copying over UFs to the term translator cache
  • as part of that change, it makes use of an updated interface for getting free symbols from smt-switch.
  • it factors out the check for supported logics in the TS so that IC3IA can run on systems with uninterpreted sorts, UFs and arrays.

@makaimann makaimann added bugfix Fixes a bug do not merge Don't merge this pull request yet (waiting on something or not yet ready). labels Nov 13, 2020
@makaimann
Copy link
Collaborator Author

This should not be merged until stanford-centaur/smt-switch#127 is merged. Additionally, the setup-smt-switch.sh script should be updated to point at master instead of the branch after that has been merged.

@makaimann
Copy link
Collaborator Author

If you'd like to test it, you can run on the simple example with:
./pono -v 1 -e ic3ia --ceg-prophecy-arrays ../samples/array_lt200.btor2

ahmed-irfan
ahmed-irfan reviewed Nov 13, 2020
View reviewed changes
@makaimann makaimann removed the do not merge Don't merge this pull request yet (waiting on something or not yet ready). label Nov 13, 2020
@makaimann
Copy link
Collaborator Author

stanford-centaur/smt-switch#127 has been merged and I updated the smt-switch setup script to pull the master branch again.

ahmed-irfan
ahmed-irfan approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@ahmed-irfan ahmed-irfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall -- just a minor comment.

@makaimann
Copy link
Collaborator Author

Thanks for the review!

@makaimann makaimann merged commit c3e5e4a into master Nov 14, 2020
@makaimann makaimann deleted the ic3ia-improvements branch November 14, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmed-irfan ahmed-irfan ahmed-irfan approved these changes

Assignees

@ahmed-irfan ahmed-irfan

Labels

bugfix Fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makaimann @ahmed-irfan