Minor changes to reflect smt-switch API changes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a recent meeting, we got some feedback on smt-switch and there's a pull request there which improves the API (stanford-centaur/smt-switch#25). This pull request simply makes the necessary changes to
cosa2to reflect those changes.In particular:
make_value->make_termmake_symbolTermTranslatorobject that moves arbitrary terms to terms that can be used by a particular solver (given to the translator in the constructor). It keeps an internal cache.Once this is approved, it can be merged as soon as the
smt-switchpull request is merged. At that point, we should revert 347934e so that it doesn't pull from thesmt-switchbranch.