Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add creation of icons for .desktop file #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2018
Merged

Add creation of icons for .desktop file #708

merged 3 commits into from
May 5, 2018

Conversation

@joede
Copy link
Contributor

@joede joede commented Apr 17, 2018

The GUI doesn't provide the icons needed to work with the .desktop file. See #684! With this PR, I've added a script to create the necessary hicolor icons from the given SVG file.

I'm no CMake user, so I don't know how to add the .desktop and the icons to CMakelist.txt. After the installation is added to the CMakelist.txt, the debian/stlink-gui.install must be patched too.

This is still needed:

  • copy stlink.desktop as stlink-gui.desktp to /usr/share/applications/ (${CMAKE_INSTALL_DATADIR}/applications/?)
  • copy stlink-gui.xpm to /usr/share/pixmaps/
  • copy hicolor/* to /usr/share/icons/hicolor/
  • copy stlink-gui_icon.svg to /usr/share/icons/hicolor/scalable/stlink-gui.svg

@joede joede mentioned this pull request Apr 17, 2018
Closed
@xor-gate
Copy link
Member

Maybe @Vascom can help you out with this?

@Vascom
Copy link
Contributor

Vascom commented Apr 17, 2018

As I found it is enough have only svg file.

@xor-gate
Copy link
Member

xor-gate commented May 2, 2018

This PR has been catching dust, @joede could you verify svg is enough?

@joede
Copy link
Contributor Author

joede commented May 2, 2018

@xor-gate I can try it within the next days. I expect that GNOME should work with this, but I can't say which other desktops needs images. So I only can test the icon usage with GNOME3!

@joede
Copy link
Contributor Author

joede commented May 2, 2018

OK, the icon is visible in GNOME3.

I've updated to PR to install the .desktop and the SVG icon with the Debian package. Therefore I have renamed the two files to stlink-gui.* which is IMO better. I have removed the installation instructions from the main CMakeList.txt to the CMakeList.txt of the stlink-gui one. Now all GUI related action is inside this file and no longer spread over two files.

Again: I don't know if the images are necessary for other desktops! Not all desktops use SVG...

@Vascom
Copy link
Contributor

Vascom commented May 3, 2018

I suggest leaving only SVG and keeping track of bug reports.

@xor-gate
Copy link
Member

xor-gate commented May 5, 2018

@Vascom agreed

@xor-gate xor-gate merged commit 0af68c0 into stlink-org:master May 5, 2018
@xor-gate xor-gate added this to the Next milestone May 5, 2018
@xor-gate
Copy link
Member

xor-gate commented May 5, 2018

Thanks @joede for your contribution.

@Nightwalker-87 Nightwalker-87 linked an issue Mar 18, 2020 that may be closed by this pull request
Please add png icon #684
Closed
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

code/feature-request component/stlink-gui os/linux status/resolved

Projects

None yet

Milestone

v1.5.1

Development

Successfully merging this pull request may close these issues.

Please add png icon

4 participants

@joede @xor-gate @Vascom @Nightwalker-87