Mem write odd #730
Merged
Mem write odd #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculation of *ret for EOF case.
of a file. fread (on stm32) get them (say 3 bytes), then askes for more. do_semihosting gets a read return of 0 and tries to write that. mem_write alters the address to be aligned and overwrites then 3 bytes from the last read. This change simply tells mem_write to do nothing if len is 0.
Add more comments on further possible issues and ways to handle them. Using a branch to separate this change from others as it may need more discussion and go on for a while...
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
and the compiler should be fine with that without any cast.
|
This is a good fix, checking before calculation is always a good idea to not go beyond boundaries. Thanks! |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first fix to mem_write() again. This is simply to have it return when len == 0 and that solves my issues with reading at the end of a file when the remaining data is not an even multiple of 4 bytes.
I have also recognized that this function will overwrite target data that is shouldn't if it is ever called with a non-zero length and either the address or length is not a multiple of 4. I don't know if that situation will ever occur, it does not happen in my limited uses (so far :-) ). I have added some comments with possible ways to address that issue.