Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Enhancement] Add date retention functionality for STM32F1xx based boards#41

Closed
josh-gaby wants to merge 12 commits intostm32duino:mainfrom
josh-gaby:master
Closed

[Enhancement] Add date retention functionality for STM32F1xx based boards#41
josh-gaby wants to merge 12 commits intostm32duino:mainfrom
josh-gaby:master

Conversation

@josh-gaby
Copy link

@josh-gaby josh-gaby commented Sep 23, 2020

Adds date retention through power cycles on stm32f1xx based boards

On these chips, the date details are only stored in SRAM while running, because of this, dates are not being retained after a power off even with VBAT connected.

This is fixed by using backup registers DR2 and DR3 to store the date data each time it is updated. Doing this means that the date can then be extracted and set correctly when the RTC is next initialized.

@josh-gaby josh-gaby closed this Sep 23, 2020
@josh-gaby josh-gaby reopened this Sep 23, 2020
@josh-gaby josh-gaby closed this Sep 23, 2020
Add date retention functionality
8b190ac 
Add date retention functionality for STM32F1xx based boards
@josh-gaby josh-gaby reopened this Sep 23, 2020
Update rtc.c
6c5a4a4 
Remove spaces to pass AStyle check
@fpistm fpistm added the enhancement New feature or request label Sep 23, 2020
@fpistm fpistm added this to the 1.1.0 milestone Sep 23, 2020
@fpistm fpistm mentioned this pull request Sep 23, 2020
Closed
@fpistm
Copy link
Member

fpistm commented Sep 23, 2020

Hi @josh-gaby
Thanks for moving this PR here.

Update rtc.c
d19eb8f 
Only run RTC_StoreDate from the SetDate function if running on stm32f1xx
@josh-gaby josh-gaby mentioned this pull request Sep 24, 2020
Closed
Josh added 2 commits September 25, 2020 11:19
Update rtc.c
fc177b4 
Store the date after a rollover on power up or it will revert if power is lost again before manually changeing or another rollover occurs.
Update rtc.c
58c2ffd
@fpistm fpistm requested a review from FRASTM January 5, 2021 10:09
FRASTM
FRASTM reviewed Jan 5, 2021
View reviewed changes
JakubRakus
JakubRakus reviewed Feb 23, 2021
View reviewed changes
Josh added 6 commits February 24, 2021 12:00
Backup register
7ad76de 
Add a backup register definition
Update rtc.c
084255c 
Fix code styling
Update rtc.h
40131d0 
Correct backup register
Weekday retention
c2d233f 
Retain weekday through power cycle
Update rtc.c
174b3eb 
Add check for valid weekday when restoring date
Update rtc.c
89f9ab0 
Fix typo
JakubRakus
JakubRakus reviewed Feb 25, 2021
View reviewed changes
Update rtc.c
fc90064 
Include missing header file
@bxparks bxparks mentioned this pull request Mar 6, 2021
Closed
@fpistm
Copy link
Member

fpistm commented Apr 20, 2021

Hi @josh-gaby
Seems this PR does not cover all possible case (mainly when date change during a sleep mode):
bxparks/AceTime#50 (comment)

I don't think I'm a fan of this PR, because if I understand it correctly, the date is not updated while the microcontroller is powered-down. The date is only preserved, so it is good for short power-loss. If the controller is powered down for more than 24 hours (or maybe even across the 23:59 -> 24:00 transition), the date is incorrect.

I think using epoch time to restore the date is a better solution and will cover all the case.

@fpistm fpistm modified the milestones: 2.0.0, 2.x.x Apr 22, 2021
@fpistm fpistm modified the milestones: 1.1.1, 1.2.0 Oct 1, 2021
@fpistm fpistm linked an issue Nov 17, 2021 that may be closed by this pull request
times reset after power cycle #32
Closed
FRASTM
FRASTM reviewed Nov 23, 2021
View reviewed changes
@FRASTM
Copy link
Contributor

FRASTM commented Nov 23, 2021

Thanks to a "magic nb" in another backUp register, there is a simple way to detect if the Vbat was powered during Vdd OFF.
Then the date read is considered as valid or not.

@FRASTM
Copy link
Contributor

FRASTM commented Dec 1, 2021 •
edited
Loading

This proposal looks like a custom appli as long as only the date is kept (stored) on each call to rtc.setDate.
Keeping the date and/or time in the backUp reg will guarantee that, on the next Reset, the RTC will start counting from this value and not from 0.
It should be extended to date and time (checking the 'reset' flag of the RTC_init). This is quite simple when Read/Writing the RTC CNT counter registers exporting cube HAL functions (just like the MBED did for the stm32F1)

On the stm32F1 there is one-second interrupt (see #57) that could help storing the new Date and/or Time in BackUp Registers.
In any case the RTC and backup Registers can be powered by the Vbat and kept supplied when the main Vdd is off.
If not the content is lost.

@josh-gaby
Copy link
Author

josh-gaby commented Dec 1, 2021

Its been awhile since I've had a chance to work on this, I will try and get back on it this weekend.

@FRASTM FRASTM mentioned this pull request Dec 3, 2021
Merged
@drbachler
Copy link

drbachler commented Dec 12, 2021

I just ran into this, would be awesome to get this fix across the line and merged.

@fpistm fpistm removed a link to an issue Dec 15, 2021
times reset after power cycle #32
Closed
@fpistm fpistm added the duplicate This issue or pull request already exists label Dec 16, 2021
@fpistm
Copy link
Member

fpistm commented Dec 16, 2021

I close this PR as it is superseded by #58.

@fpistm fpistm closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm left review comments

@FRASTM FRASTM FRASTM left review comments

+1 more reviewer

@JakubRakus JakubRakus JakubRakus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

duplicate This issue or pull request already exists enhancement New feature or request

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@josh-gaby @fpistm @FRASTM @drbachler @JakubRakus