Fix various warning issues#410
Merged
aytey merged 3 commits intostp:masterfrom Jul 29, 2021
fortify-iq:fix-warnings-issues
Merged
Fix various warning issues#410aytey merged 3 commits intostp:masterfrom fortify-iq:fix-warnings-issues
aytey merged 3 commits intostp:masterfrom
fortify-iq:fix-warnings-issues
Conversation
aytey
requested changes
Jul 29, 2021
Member
aytey
left a comment
There was a problem hiding this comment.
Seems like a good first attempt; some minor comments just to clean some edges up.
Contributor
Author
|
@andrewvaughanj Thanks! I applied all discussed suggestions. |
aytey
reviewed
Jul 29, 2021
aytey
reviewed
Jul 29, 2021
aytey
reviewed
Jul 29, 2021
Member
|
One last comment from me (the one on Have you tested that this "all works" for your purposes (apart from the message bits)? |
Contributor
Author
Yes! |
Member
|
Thanks, @Shatur! |
Contributor
Author
Opened a separate PR: #411. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some warnings (except for some warnings coming from ABC, which should be fixed on the ABC side, and some warnings can't be fixed properly without C++17), slightly modernizes CMake and adds the ability to suppress warnings at all.
Each commit is a separate edit.
Closes #409.