Ensuring that STP's Travis scripts match the lingeling test repo#359
Merged
msoos merged 2 commits intostp:masterfrom Jul 9, 2020
Merged
Ensuring that STP's Travis scripts match the lingeling test repo#359msoos merged 2 commits intostp:masterfrom
msoos merged 2 commits intostp:masterfrom
Conversation
Signed-off-by: Andrew V. Jones <[email protected]>
Member
Author
|
Okay, not as easy as I'd hoped. I didn't check this originally, but https://github.com/msoos/lingeling-ala does not build I opened-up this PR msoos/lingeling-ala#1 to ensure we build |
Signed-off-by: Andrew V. Jones <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The build scripts that Travis runs point to @msoos's personal copy of Lingeling -- this repo recently got changed to not have a
./configurescript and to use CMake instead.See: msoos/lingeling-ala@6848f4e
Resolution
This PR fixes Travis's steps to use CMake rather than calling
./configurefor Lingeling.Questions
@msoos do you think it is worthwhile adding
msoos/minisat,msoos/cryptominisat,conp-solutions/riss,klee/klee-uclibc,msoos/fuzzsmt,msoos/lingeling-alaandmsoos/boolector-1.5.118as submodules to STP? This would avoid these breakages.These list of repos are those which come from
scripts/travis-cmake.sh.Signed-off-by: Andrew V. Jones [email protected]