Do not set default timestamp value for date types #4125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexandrebodin This is fine and what I had intended too. I put off making changes until @soupette was ready for me to add the frontend parts from Buffet. But for now the backend should be fine, we just need to make sure the current adminUI can render this with current tooling. |
derrickmehaffy
approved these changes
Sep 27, 2019
This was referenced Jan 12, 2022
This was referenced Mar 20, 2022
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
This will leave date types with default null except for created_at and updated_at. this isn't ideal for now because we still set any timestamp with a default time but it isn't a user interface field and will be changed later on
Fix #2300
Replaces the PR #4019
My PR is a:
Main update on the:
Manual testing done on the following databases: