Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Bassel17
Copy link
Member

@Bassel17 Bassel17 commented Oct 15, 2025

What does it do?

  • Adds support for node 24, drops node 18
  • adds node 24 to the tests matrix

Why is it needed?

  • node 24 is in LTS
  • node 18 end of life was 5 month ago

How to test it?

  • All tests should run successfully
  • experimental: 0.0.0-experimental.1827b02a6ce14d67bfd14ebe164a8039ef6ca2f3

resolves #24731

@Bassel17 Bassel17 added this to the 5.28.1 milestone Oct 15, 2025
@Bassel17 Bassel17 self-assigned this Oct 15, 2025
@Bassel17 Bassel17 added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Oct 15, 2025
@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
contributor-docs Ready Ready Preview Comment Nov 10, 2025 10:23am

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I remember from past updates:

  • there may be a grid in a readme of recommended versions to update (can't remember)
  • there is some code that runs on startup and reinforces the node engines at runtime (or logs a warning?) that should be updated

@trunk-io
Copy link

trunk-io bot commented Oct 15, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@innerdvations
Copy link
Contributor

  • there is some code that runs on startup and reinforces the node engines at runtime (or logs a warning?) that should be updated

Ok, I checked this and it's built so that it doesn't need to be manually updated anymore.

We may want to set the .nvmrc to 24

@innerdvations
Copy link
Contributor

Also, we might need to:

  • update the @types/node packages
  • update @tsconfig/node18

@hanpaine hanpaine added the flag: don't merge This PR should not be merged at the moment label Oct 17, 2025
@hanpaine
Copy link
Contributor

We need to wait for Cloud to update before we can merge this or it'll break any builds on 24.

@Bassel17 Bassel17 removed this from the 5.29.0 milestone Oct 17, 2025
@oiorain oiorain mentioned this pull request Oct 30, 2025
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Size Change: -242 kB (-2.04%)

Total Size: 11.6 MB

Filename Size Change
examples/getstarted/build/ComponentConfigurationPage-*********** 1.52 kB +5 B (+0.33%)
examples/getstarted/build/EditConfigurationPage-*********** 1.08 kB +5 B (+0.47%)
examples/getstarted/build/EditPage-*********** 2.09 kB +200 B (+10.58%) ⚠️
examples/getstarted/build/HomePage-*********** 237 B -246 kB (-99.9%) 🏆
examples/getstarted/build/hooks-*********** 82 B -10 B (-10.87%) 👏
examples/getstarted/build/index-*********** 6.1 kB +5.93 kB (+3573.49%) 🆘
examples/getstarted/build/ListPage-*********** 3.45 kB +1.53 kB (+80.14%) 🆘
examples/getstarted/build/ListView-*********** 1.36 kB -5.44 kB (-80%) 🏆
examples/getstarted/build/Settings-*********** 1.83 kB +227 B (+14.13%) ⚠️
examples/getstarted/build/SettingsPage-*********** 3.72 kB +1.9 kB (+103.95%) 🆘
examples/getstarted/build/strapi-*********** 1.77 MB +30 B (0%)
examples/getstarted/build/Widgets-*********** 977 B -104 B (-9.62%) 👏
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/_baseEach-*********** 218 B -3 B (-1.36%)
examples/getstarted/build/_baseMap-*********** 191 B +1 B (+0.53%)
examples/getstarted/build/AdminSeatInfo-*********** 833 B -1 B (-0.12%)
examples/getstarted/build/AIUsage-*********** 701 B -3 B (-0.43%)
examples/getstarted/build/apiTokens-*********** 465 B 0 B
examples/getstarted/build/App-*********** 9.03 kB -2 B (-0.02%)
examples/getstarted/build/ApplicationInfoPage-*********** 4.39 kB +1 B (+0.02%)
examples/getstarted/build/ar.json-*********** 5.38 kB 0 B
examples/getstarted/build/AuthenticatedLayout-*********** 16.8 kB +3 B (+0.02%)
examples/getstarted/build/AuthResponse-*********** 421 B +1 B (+0.24%)
examples/getstarted/build/ca.json-*********** 9.93 kB 0 B
examples/getstarted/build/CardDragPreview-*********** 586 B 0 B
examples/getstarted/build/ColorPickerInput-*********** 4.23 kB -1 B (-0.02%)
examples/getstarted/build/ConfigureTheView-*********** 1.53 kB -4 B (-0.26%)
examples/getstarted/build/constants-*********** 72 B 0 B
examples/getstarted/build/CreateActionEE-*********** 499 B -4 B (-0.8%)
examples/getstarted/build/CreatePage-*********** 1.94 kB 0 B
examples/getstarted/build/CreateView-*********** 306 B +1 B (+0.33%)
examples/getstarted/build/cs.json-*********** 338 B 0 B
examples/getstarted/build/de.json-*********** 9.75 kB 0 B
examples/getstarted/build/dk.json-*********** 3.6 kB 0 B
examples/getstarted/build/dummy-preview-*********** 3.05 kB -2 B (-0.07%)
examples/getstarted/build/EditView-*********** 2.02 kB +2 B (+0.1%)
examples/getstarted/build/EditViewPage-*********** 5.14 kB -1 B (-0.02%)
examples/getstarted/build/en-*********** 74 B 0 B
examples/getstarted/build/en-GB-*********** 15.2 kB 0 B
examples/getstarted/build/en.json-*********** 381 B 0 B
examples/getstarted/build/es-*********** 74 B 0 B
examples/getstarted/build/es.json-*********** 4.28 kB 0 B
examples/getstarted/build/eu.json-*********** 11.3 kB 0 B
examples/getstarted/build/EventsTable-*********** 388 B 0 B
examples/getstarted/build/FieldTypeIcon-*********** 460 B 0 B
examples/getstarted/build/Form-*********** 5.05 kB +2 B (+0.04%)
examples/getstarted/build/fr.json-*********** 794 B 0 B
examples/getstarted/build/getActionTypesDefaultMessages-*********** 499 B -1 B (-0.2%)
examples/getstarted/build/getTrad-*********** 383 B +1 B (+0.26%)
examples/getstarted/build/groupBy-*********** 369 B -1 B (-0.27%)
examples/getstarted/build/gu.json-*********** 4.48 kB 0 B
examples/getstarted/build/he.json-*********** 1.63 kB 0 B
examples/getstarted/build/hi.json-*********** 4.55 kB 0 B
examples/getstarted/build/History-*********** 6.26 kB +2 B (+0.03%)
examples/getstarted/build/hu.json-*********** 3.98 kB 0 B
examples/getstarted/build/id-*********** 7.52 kB -2 B (-0.03%)
examples/getstarted/build/id.json-*********** 1.39 kB 0 B
examples/getstarted/build/index.html 591 B -3 B (-0.51%)
examples/getstarted/build/InstalledPlugins-*********** 780 B 0 B
examples/getstarted/build/isNil-*********** 119 B -4 B (-3.25%)
examples/getstarted/build/it.json-*********** 5.51 kB 0 B
examples/getstarted/build/ja.json-*********** 1.41 kB 0 B
examples/getstarted/build/ko.json-*********** 5.2 kB 0 B
examples/getstarted/build/layout-*********** 3.31 kB +1 B (+0.03%)
examples/getstarted/build/Layout-*********** 1.95 kB 0 B
examples/getstarted/build/ListConfigurationPage-*********** 4.23 kB +2 B (+0.05%)
examples/getstarted/build/ListViewPage-*********** 6.17 kB 0 B
examples/getstarted/build/Login-*********** 456 B -4 B (-0.87%)
examples/getstarted/build/lt-*********** 2.86 kB -2 B (-0.07%)
examples/getstarted/build/MagicLinkEE-*********** 388 B +1 B (+0.26%)
examples/getstarted/build/MarketplacePage-*********** 13.8 kB 0 B
examples/getstarted/build/ml.json-*********** 11.9 kB 0 B
examples/getstarted/build/ModalForm-*********** 243 B 0 B
examples/getstarted/build/ms.json-*********** 1.18 kB 0 B
examples/getstarted/build/nl.json-*********** 1.23 kB 0 B
examples/getstarted/build/no.json-*********** 5.47 kB 0 B
examples/getstarted/build/NoContentTypePage-*********** 452 B 0 B
examples/getstarted/build/NoPermissionsPage-*********** 229 B -1 B (-0.43%)
examples/getstarted/build/Permissions-*********** 9.38 kB 0 B
examples/getstarted/build/pl.json-*********** 2.09 kB 0 B
examples/getstarted/build/PrivateRoute-*********** 249 B -1 B (-0.4%)
examples/getstarted/build/ProfilePage-*********** 2.46 kB 0 B
examples/getstarted/build/pt-BR.json-*********** 1.12 kB 0 B
examples/getstarted/build/pt.json-*********** 1.51 kB 0 B
examples/getstarted/build/purchase-review-workflows-*********** 252 kB -2 B (0%)
examples/getstarted/build/PurchaseAuditLogs-*********** 250 kB -2 B (0%)
examples/getstarted/build/PurchaseContentHistory-*********** 8.63 MB 0 B
examples/getstarted/build/PurchaseContentReleases-*********** 138 kB +1 B (0%)
examples/getstarted/build/PurchaseSingleSignOn-*********** 155 kB 0 B
examples/getstarted/build/RelativeTime-*********** 395 B -1 B (-0.25%)
examples/getstarted/build/ReleasesPage-*********** 4.08 kB -2 B (-0.05%)
examples/getstarted/build/ReleasesSettingsPage-*********** 1.51 kB +2 B (+0.13%)
examples/getstarted/build/router-*********** 398 B -1 B (-0.25%)
examples/getstarted/build/ru-*********** 91 B 0 B
examples/getstarted/build/ru.json-*********** 241 B 0 B
examples/getstarted/build/sa.json-*********** 4.6 kB 0 B
examples/getstarted/build/schemas-*********** 3.16 kB -1 B (-0.03%)
examples/getstarted/build/SearchInput-*********** 571 B -1 B (-0.17%)
examples/getstarted/build/selectors-*********** 111 B 0 B
examples/getstarted/build/SelectRoles-*********** 1.03 kB -2 B (-0.19%)
examples/getstarted/build/SingleSignOnPage-*********** 1.79 kB +2 B (+0.11%)
examples/getstarted/build/sk.json-*********** 748 B 0 B
examples/getstarted/build/sortable.esm-*********** 16.5 kB 0 B
examples/getstarted/build/sortBy-*********** 695 B -1 B (-0.14%)
examples/getstarted/build/SSOProviders-*********** 721 B 0 B
examples/getstarted/build/strapi-************ 844 B 0 B
examples/getstarted/build/sv.json-*********** 3.69 kB 0 B
examples/getstarted/build/Table-*********** 1.29 kB 0 B
examples/getstarted/build/tail-*********** 242 B -3 B (-1.22%)
examples/getstarted/build/th.json-*********** 3.28 kB 0 B
examples/getstarted/build/TokenTypeSelect-*********** 122 kB 0 B
examples/getstarted/build/tr-*********** 83 B 0 B
examples/getstarted/build/tr.json-*********** 10.7 kB 0 B
examples/getstarted/build/transferTokens-*********** 503 B -1 B (-0.2%)
examples/getstarted/build/uk-*********** 91 B 0 B
examples/getstarted/build/uk.json-*********** 3.32 kB 0 B
examples/getstarted/build/useAdminRoles-*********** 242 B 0 B
examples/getstarted/build/UseCasePage-*********** 1.36 kB -3 B (-0.22%)
examples/getstarted/build/useDragLayer-*********** 180 B 0 B
examples/getstarted/build/useLicenseLimitNotification-*********** 711 B +2 B (+0.28%)
examples/getstarted/build/useReviewWorkflows-*********** 1.33 kB -1 B (-0.08%)
examples/getstarted/build/users-*********** 352 B 0 B
examples/getstarted/build/useWebhooks-*********** 645 B +1 B (+0.16%)
examples/getstarted/build/validation-*********** 520 B -1 B (-0.19%)
examples/getstarted/build/vi.json-*********** 1.41 kB 0 B
examples/getstarted/build/WidgetHelpers-*********** 520 B -2 B (-0.38%)
examples/getstarted/build/zh-Hans.json-*********** 2.92 kB 0 B
examples/getstarted/build/zh.json-*********** 1.09 kB 0 B

compressed-size-action

@hanpaine hanpaine removed the flag: don't merge This PR should not be merged at the moment label Nov 7, 2025
@hanpaine hanpaine added this to the 5.30.2 milestone Nov 7, 2025
@Bassel17 Bassel17 merged commit 19187c0 into develop Nov 10, 2025
509 of 515 checks passed
@Bassel17 Bassel17 deleted the chore/support-node-24 branch November 10, 2025 12:35
chaitya-titan pushed a commit to chaitya-titan/strapi that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support node v24 LTS

5 participants