Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@markkaylor
Copy link
Contributor

What does it do?

  • Always return ai license enabled as false for community edition
  • Determine if EE license is Growth by first checking the license for the cms-ai feature then checking if the user has it configured. (Should always be false for a non-growth EE license)

Why is it needed?

Currently an EE license with config in admin.js:

ai: {
 enabled: true,
}

But this is not correct, it should only return true if the license actually has AI

How to test it?

Run the app with an EE license, a growth license, and in CE
Check the guided tour works in EE with and without AI
General QA of all licenses with and without AI

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@markkaylor markkaylor added this to the 5.31.1 milestone Nov 13, 2025
@markkaylor markkaylor self-assigned this Nov 13, 2025
@markkaylor markkaylor added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 13, 2025
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
contributor-docs Ready Ready Preview Comment Nov 13, 2025 9:47am

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Adzouz Adzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested and it works well on all three plans 🙌 Thanks @markkaylor 🙏

@markkaylor markkaylor changed the title fix(admin): ai can be enabled on an EE license that is not growth fix(admin): ai admin config can be set to true for non growth license Nov 13, 2025
@markkaylor markkaylor merged commit ef9fb10 into develop Nov 13, 2025
140 checks passed
@markkaylor markkaylor deleted the fix/check-license-for-ai branch November 13, 2025 10:39
@trunk-io
Copy link

trunk-io bot commented Nov 13, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug source: core:admin Source is core/admin package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants