Move type Map out of type_specific_codegen.go #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should take care of #70 |
hanzei
requested changes
May 28, 2018
type_specific.go
Outdated
|
|
||
| // MSI gets the value as a map[string]interface{}, returns the optionalDefault | ||
| // value or a system default object if the value is the wrong type. | ||
| // TODO: Find a better solution for the Map type as this code is autogenerated |
There was a problem hiding this comment.
Could you remove this comment?
type_specific.go
Outdated
| // ObjxMapSlice gets the value as a [](Map), returns the optionalDefault | ||
| // value or nil if the value is not a [](Map). | ||
| func (v *Value) ObjxMapSlice(optionalDefault ...[](Map)) [](Map) { | ||
| // TODO: Find a better solution for the Map type as this code is autogenerated |
There was a problem hiding this comment.
Could you remove this comment?
|
Removed the comments. |
hanzei
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved all MSI and ObjxMap functions to type_specific.go and added additional code for getting either types from the other within the objx.Map. Added additional tests as well.
Fixes #70