Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vyskocilm
Copy link
Contributor

Summary

objx can't work with JSON documents starting with top-level array. This
commit adds helpers FromJSONSlice and MustJSONSlice. Those returns []Map
enabling objx usage for this case as well.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Tests are passing: task test
  • Code style is correct: task lint

objx can't work with JSON documents starting with top-level array. This
commit adds helpers FromJSONSlice and MustJSONSlice. Those returns `[]Map`
enabling objx usage for this case as well.
Copy link
Collaborator

@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM other than a small change.

@geseq
Copy link
Collaborator

geseq commented Feb 4, 2021

cc @hanzei

@hanzei hanzei merged commit 6c797d8 into stretchr:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants