Handle unexpected exits in condition polling #1819
Open
+313
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fail
Eventually,Never, andEventuallyWithTwith"Condition exited unexpectedly"when the condition goroutine exits unexpectedly through
runtime.Goexit.Changes
Eventuallywhen condition does not return normally and fail fast instead.Neverwhen condition does not return normally to fail fast and prevent false positives.EventuallyWithTwhenruntime.Goexitwas not called throughcollect.FailNow.Motivation
Nevercurrently stops polling, when the condition exits. This can lead to false positives.Eventuallycurrently stop polling, when the condition exits. This prevents fast failures.EventuallyWithTdoes not fail when the outertfails.Related issues
This PR is a concise rewrite of #1809 and should fix Issue #1810.
Changed Behavior
EventuallyEventuallyWithTNever