Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ignore dep warning from asdf? #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

Ignore dep warning from asdf? #7768

merged 2 commits into from
Aug 5, 2024

Conversation

@nabobalis
Copy link
Member

@nabobalis nabobalis commented Aug 3, 2024 •
edited
Loading 

UNEXPECTED EXCEPTION: DeprecationWarning('The `hash` argument is deprecated in favor of `unsafe_hash` and will be removed in or after August 2025.')
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.4/x64/lib/python3.12/doctest.py", line 1368, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest 5.0.rst[0]>", line 1, in <module>
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/sunpy/net/__init__.py", line 7, in <module>
    from sunpy.net import base_client as _
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/sunpy/net/base_client.py", line 12, in <module>
    from astropy.table import Column, QTable, Row, Table, TableAttribute
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/astropy/table/__init__.py", line 127, in <module>
    import asdf_astropy.io.connect
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf_astropy/io/connect.py", line 4, in <module>
    import asdf
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/__init__.py", line 20, in <module>
    from ._asdf import AsdfFile
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_asdf.py", line 12, in <module>
    from . import _compression as mcompression
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_compression.py", line 8, in <module>
    from .config import get_config
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/config.py", line 11, in <module>
    from . import _entry_points, util, versioning
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_entry_points.py", line 10, in <module>
    from .exceptions import AsdfWarning
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/exceptions.py", line 1, in <module>
    from asdf._jsonschema import ValidationError
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_jsonschema/__init__.py", line 13, in <module>
    from asdf._jsonschema._format import FormatChecker
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_jsonschema/_format.py", line 11, in <module>
    from asdf._jsonschema.exceptions import FormatError
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 174, in exec_module
    exec(co, module.__dict__)
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/asdf/_jsonschema/exceptions.py", line 179, in <module>
    @attr.s(hash=True)
     ^^^^^^^^^^^^^^^^^
  File "/home/runner/work/sunpy/sunpy/.tox/py312/lib/python3.12/site-packages/attr/_make.py", line 1291, in attrs
    warnings.warn(
DeprecationWarning: The `hash` argument is deprecated in favor of `unsafe_hash` and will be removed in or after August 2025.

@nabobalis nabobalis added No Changelog Entry Needed Skip all changelog checks. Infrastructure Issues or PRs that affect the CI or packaging. Minor Change PR only needs one approval to merge. backport 6.0 labels Aug 3, 2024
braingram
braingram approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf 3.4.0 is out with a fix to prevent this new deprecation warning (which is coming from attrs: python-attrs/attrs#1323).

However I think it will still appear in the oldest deps so filtering the warning marks sense to me.

@nabobalis @braingram
Update pytest.ini
e6fe6cb 
Co-authored-by: Brett Graham <[email protected]>
@nabobalis
Copy link
Member Author

nabobalis commented Aug 4, 2024

asdf 3.4.0 is out with a fix to prevent this new deprecation warning (which is coming from attrs: python-attrs/attrs#1323).

However I think it will still appear in the oldest deps so filtering the warning marks sense to me.

Thanks!

@jrdnbradford jrdnbradford mentioned this pull request Aug 5, 2024
Closed
@wtbarnes
Copy link
Member

wtbarnes commented Aug 5, 2024

That windows fail looks real but unrelated to this PR.

@Cadair Cadair merged commit cc7d5d9 into sunpy:main Aug 5, 2024
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Aug 5, 2024
@Cadair @meeseeksmachine
Backport PR sunpy#7768: Ignore dep warning from asdf?
0a531b1
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 5, 2024
Merged
Cadair added a commit that referenced this pull request Aug 5, 2024
@Cadair
Merge pull request #7770 from meeseeksmachine/auto-backport-of-pr-776…
abef06f 
…8-on-6.0

Backport PR #7768 on branch 6.0 (Ignore dep warning from asdf?)
@nabobalis nabobalis deleted the fix_ci branch May 16, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

+1 more reviewer

@braingram braingram braingram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure Issues or PRs that affect the CI or packaging. Minor Change PR only needs one approval to merge. No Changelog Entry Needed Skip all changelog checks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nabobalis @wtbarnes @braingram @Cadair