Adding ability to query over SOOP name #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess a question here - should we remove that a.Time is a required attr? I could imagine a case when someone just wants to query solely based on SOOP for example. |
Sounds sensible to me. Could we get a attrs unit test for soup and maybe a query for some soop search results? |
nabobalis
approved these changes
May 10, 2023
nabobalis
reviewed
May 10, 2023
|
Thanks for doing this @hayesla. I have tagged 1.8 as well, so it should be public soon. |
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a new attrs
a.soar.SOOPand allows the users to construct a query based on a SOOP name.Fixes #73