Conversation
This commit adds a new method `grayscale` to the Colorus class. The `grayscale` method converts the current color to grayscale, with an option to use the NTSC formula for conversion. Additionally, Jest tests have been added to ensure the correctness of the grayscale conversion functionality. The tests cover various scenarios, including conversion without the NTSC formula, conversion with the NTSC formula, preservation of alpha channel, and handling of black and white colors. **Details:** - Added `grayscale` method to the Colorus class - Implemented grayscale conversion using the rgbToGray function from compose module - Added Jest tests for the grayscale method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new method
grayscaleto the Colorus class. Thegrayscalemethod converts the current color to grayscale, with an option to use the NTSC formula for conversion. Additionally, Jest tests have been added to ensure the correctness of the grayscale conversion functionality.The tests cover various scenarios, including conversion without the NTSC formula, conversion with the NTSC formula, preservation of alpha channel, and handling of black and white colors.
Details:
grayscalemethod to the Colorus class