This repository was archived by the owner on Nov 1, 2021. It is now read-only.
Fix cursor visibility on surface commit #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That seems like a good idea. Can you try doing this? |
|
This emits request_set_cursor twice on every surface entry so it's not perfect. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spawning a new window in Rootston the cursor will disappear if it is over the surface. It is supposed to be set to a surface specific cursor. I think this is caused by the client sending an empty cursor surface when requested causing cursor->visible to be set to false. The surface is then committed but the visibility is not updated so it stays hidden until it registers movement.
I'm unsure if I put it in the correct place though. Maybe it should be called inside output_cursor_commit since it updates the dimenstions, I don't know what consequences that will have though.