This repository was archived by the owner on Nov 1, 2021. It is now read-only.
Render software cursors in compositor #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
806d87d to
63bafe1
Compare
|
Can you make a PR for sway? |
This wasn't using direct scan-out. Direct scan-out will probably work differently with @ascent12's work anyway.
Rendering in wlr_output_swap_buffers has unfortunate side-effects.
63bafe1 to
1b9ebcf
Compare
|
Rebased |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
wlr_output_set_fullscreen_surface, adds a newwlr_output_render_software_cursorshelper, and removes the 180 damage flip inwlr_output_swap_buffers(which is GL-specific).This also fixes frame events for hardware cursors, which were sent too soon.
While this improves the situation, this doesn't completely fix #1363, because redesigning how cursor surfaces are handled and how output damage is managed requires more thought.
See #1363