Add SendMessage, ReceiveMessage and RetractMessage to MIX #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates MIXJoin Element list of subscriptions to an unordered_set. Remove redundant MIXSubscribe Element. License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details. Test-Information: Added tests for MIXUpdateSubscription Parser and Serializer based on examples in XEP 0369, which passes. Tested on Ubuntu 16.04 LTS. Change-Id: Ied06269cf329b4fdffdde4ace67ebffa4089fbde
Updates MIXJoin Element list of subscriptions to an unordered_set. Remove redundant MIXSubscribe Element. License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details. Test-Information: Tests added for joining and leaving a channel as in XEP-0369, which passes. Tested on Ubuntu 16.04 LTS. Change-Id: Ibc2737f6154eeee1a85e98cb5f80c8bdbad35dcd
Add MIXRetract element, its parser and serializer License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details. Test-Information: Added tests for SendMessage, ReceiveMessage and RetractMessage, which passes. Added tests for MIXRetract Parser and Serializer based on examples in XEP 0369, which passes. Tested on Ubuntu 16.04 LTS. Change-Id: I65555a9129c2eccd632861259be92e2be607ee64
tfar
requested changes
Jul 18, 2017
| /** | ||
| * Join a MIX channel and subscribe to nodes. | ||
| */ | ||
| virtual void joinChannelAndSubscribe(const JID &channel, const std::unordered_set<std::string>& nodes) = 0; |
There was a problem hiding this comment.
An object which conforms to the MIX interface is supposed to represent a single client <-> MIX channel relation. So the channel is going to be the same for all methods and probably passed in the constructor.
| for (auto node : nodes) { | ||
| joinPayload->addSubscription(node); | ||
| } | ||
| auto request = std::make_shared<GenericRequest<MIXJoin> >(IQ::Set, getJID(), joinPayload, iqRouter_); |
There was a problem hiding this comment.
Please use >> instead of > >.
tfar
reviewed
Jul 18, 2017
|
|
||
| virtual void leaveChannel(const JID &channel) = 0; | ||
|
|
||
| virtual void sendMessage(const JID &channel, const std::string &body) = 0; |
There was a problem hiding this comment.
This should probably take something more flexible than std::string. What if you want to send XHTML-IM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.