Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@LecrisUT
Copy link

@LecrisUT LecrisUT commented Jun 28, 2023

It is time to modernize the cmake configurations. The goal of this PR is:

  • Make the project importable via FetchContent
  • Fix bad practices like lacking namespace options, using cache variables on CMAKE variables, etc.
  • Use more cmake native functions, e.g. project(VERSION)
  • Add a proper installer for find_package
  • Migrate the code of UseSwig to upstream
  • Add tests to ctest
    • error-test-suite: The only tests run on test-toolchain
    • Example: These are worth exposing to other test suites as well
    • languages: This I think using something like tmt could make it cleaner. I don't think I have a simple approach to mimic the test procedure in autotools with ctest only, e.g. python test adds a check_pep8 which would make it trickier to chain and run the tests
  • Update the github action for cmake

This PR will make it possible for other projects to import unmerged swig module like fortran, as well as any other fixes in the works.

Depends-on: #2647

@LecrisUT LecrisUT marked this pull request as draft June 28, 2023 09:47
@LecrisUT LecrisUT force-pushed the cmake/cmake branch 5 times, most recently from 3aaf779 to 176e0ea Compare June 28, 2023 13:40
Signed-off-by: Cristian Le <[email protected]>
Avoids duplication of jobs and concurrency issues

Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT mentioned this pull request Aug 30, 2023
7 tasks
- Use `fmf` to simplify the metadata for each toolchain and language check
- Trigger language test only if corresponding files are changed
- Always trigger all tests if a base swig file is changed

Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
- Added basic options
- Moved source definitions in individual files
- Added install/export instructions
- Removed CPack
- Moved autotools mimicking to MimickAutotools
- Prepare testing infrasturcture

Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant