-
Couldn't load subscription status.
- Fork 1.3k
Feature/new objc #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/new objc #2791
Conversation
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11208 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11313 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11314 626c5289-ae23-0410-ae9c-e8d60b6d4f22
…for primitive types). git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11363 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11364 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11365 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11381 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11383 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11384 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11387 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11403 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11416 626c5289-ae23-0410-ae9c-e8d60b6d4f22
…l variables. git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11429 626c5289-ae23-0410-ae9c-e8d60b6d4f22
…ement part]. git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11437 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11439 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11445 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11446 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11499 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11516 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11517 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11560 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11561 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11562 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11586 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11587 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11588 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11612 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11613 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11614 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2009-ashishs99@11615 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2012-objc@13662 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2012-objc@13683 626c5289-ae23-0410-ae9c-e8d60b6d4f22
git-svn-id: https://swig.svn.sourceforge.net/svnroot/swig/branches/gsoc2012-objc@13684 626c5289-ae23-0410-ae9c-e8d60b6d4f22
objc.swg: fixed check of pointer to boolean. Fixes swig#547
… into feature/new_objc # Conflicts: # COPYRIGHT # Examples/Makefile.in # Examples/test-suite/ignore_template_constructor.i # Examples/test-suite/import_nomodule.i # Makefile.in # Source/Makefile.am # Source/Modules/swigmain.cxx # configure.in
|
@wsfulton Hello, could you please review whether this version can be merged into the master branch |
|
Hi @CancerQ. Thanks for updating this stale old branch. The original work was never merged to master because it was incomplete. In order to be considered for code review, can you please provide your thoughts on what still needs to be done according to the criteria for acceptance as outlined in https://swig.org/Doc4.2/Extending.html#Extending. BTW, I've cancelled the last two builds running on CI, https://github.com/swig/swig/actions. You made 5 commits in one hour which resulted in 5 full builds of all languages. We need to be mindful of using up Github CI resources as each CI run uses a lot of compute. I suggest that once you've outlined what you plan to do to get this branch ready for review, you develop it in your own repo with CI turned off except for Objective C and post comments here with regard to progress. |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial review comments.
| * deprecated APIs and other features. | ||
| * ----------------------------------------------------------------------------- */ | ||
|
|
||
| char cvsroot_warn_c[] = "$Id$"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't start reintroducing these - they haven't been useful since we stopped using CVS, and were cleaned up over 10 years ago (7841a0d).
|
|
||
| /* please leave 900-919 free for ObjectiveC */ | ||
|
|
||
| /* -- User defined warnings (920 - 999) -- */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
900-999 are documented in the manual as reserved for use by the user (see Warnings.html), so you can't just commandeer them like this.
There are unused ranges in the block marked for use by target language modules - e.g. 760-799.
|
|
||
| %define specialize_std_map_on_both(K,CHECK_K,CONVERT_K_FROM,CONVERT_K_TO, T,CHECK_T,CONVERT_T_FROM,CONVERT_T_TO) | ||
| #warning "specialize_std_map_on_both ignored - macro is deprecated and no longer necessary" | ||
| %enddef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| %define specialize_std_vector(T) | ||
| #warning "specialize_std_vector - specialization for type T no longer needed" | ||
| %enddef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not useful for a new target language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojwb Are these four issues the only thing stopping this pull request from being merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as I said above (with new emphasis): "Some initial review comments"
If you're serious about picking up this work, start with wsfulton's question:
In order to be considered for code review, can you please provide your thoughts on what still needs to be done according to the criteria for acceptance as outlined in https://swig.org/Doc4.2/Extending.html#Extending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see why the objective-c support hasn't been added yet. There is just too much work to do for one person to handle. We need a way to break up the work into manageable units.
|
@CancerQ please respond to my question from 3 weeks ago otherwise we will have no option to assume this is not a serious proposal to update and maintain ObjectiveC support in SWIG. |
|
@CancerQ Do you still plan on working on this pull request, or would you prefer someone else take over? |
|
@cancerq Please can you merge objective-c support in swig so we can make wrapper of ifc can you @programmingkidx or @Yize9 @wsfulton take over this is very important to have support for objective-c for using c library’s @ojwb can you just review ago be according acceptable standards for master and then we would see what needed to be feature full |
|
Sorry, I have very limited time available and I'm not going to waste it reviewing this further - it's been over a year since my initial review and nobody's even bothered to make the easy updates to address the problems I highlighted then. There's clearly interest in having objc as a target language, but nobody wants to put in the hard yards to actually make that happen. |
|
@wsfulton @ojwb can you run copilot on this files to see what he is thinking what is missing to align with missing elements from https://swig.org/Doc4.2/Extending.html#Extending , and second to take fast flight through code to correct old cvs stuff and depreciated macros and stuff to put this into master if there is a not lot of work 🙏💪 btw. If this is not in master people can’t use it and if can’t use it , we can see what missing or stuff which doesn’t work so can you put this into master as we say Minimum Viable Product (MVP) in agile. |
|
Please stop @-mentioning me - that's just rude when nothing has actually changed here. It's been clearly stated above what's needed from people wanting to progress this, so if you want it to progress please do that rather than creating noise which sucks up more of my very limited time for working on SWIG. We need a new target language to achieve certain targets before it can be merged based on past experience of merging half-written target languages and that working out badly. If people want to try out the work in progress they can check out the PR branch and build that - it shouldn't really be any different to building the main branch. |
Based on the 4.2 branch, merge 2012objc and modify some code