feat: filter by full path (prefix + filename) in search view instead of just filename
#2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew instead of just filename
There was a problem hiding this comment.
Pull Request Overview
This PR enables filtering search results by the full path (prefix/filename) instead of only the filename.
- Implements
AsRef<OsStr>forUrnto allow matching on the complete path. - Updates all
partition(... filter.matches(...))calls inFilesto useu.as_urn()(full path) rather than.name().
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yazi-shared/src/url/urn.rs | Add AsRef<OsStr> impl on Urn for path matching |
| yazi-fs/src/files.rs | Change filter logic to use full Urn instead of name |
Comments suppressed due to low confidence (2)
yazi-fs/src/files.rs:191
- Add unit tests to verify that filtering by the full path (including directory prefixes) works as intended, covering both matching and non-matching scenarios.
.partition(|u| (!self.show_hidden && u.as_urn().is_hidden()) || !filter.matches(u.as_urn()))
yazi-shared/src/url/urn.rs:39
- [nitpick] Consider adding a doc comment explaining why
AsRef<OsStr>is implemented forUrn(e.g., to support full-path filtering in the search view).
impl AsRef<OsStr> for Urn {
2 tasks
xeysz
pushed a commit
to xeysz/yazi
that referenced
this pull request
Jun 27, 2025
…d of just filename (sxyazi#2915)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the feature request: #2565, #2894
The search view flatly shows search results, for example,
a/b/c.txt, wherea/bis the prefix andc.txtis the file name.Previously, users could only use the
filtercommand to filter for the file name portion (c.txt) within the search results.With this PR, the full path
a/b/c.txtcan now be filtered, which makes it more intuitive, as users should be able to filter for the path as they see it in the list, rather than only the final part of it.1.mp4