fix: erase overlapping image portions when previewing errors #3067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where overlapping image portions remain visible when previewing errors in the Yazi file manager. The fix ensures that error messages properly clear the display area before rendering.
- Modifies error rendering to explicitly clear the display area before showing error text
- Updates PDF plugin to handle page bounds more efficiently by returning bound information from preload
- Simplifies image plugin error handling by removing redundant area and wrap specifications
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yazi-plugin/src/utils/preview.rs | Adds explicit area clearing before rendering error messages |
| yazi-plugin/preset/plugins/pdf.lua | Refactors page bound handling to return bound info from preload function |
| yazi-plugin/preset/plugins/image.lua | Simplifies error handling by removing redundant UI specifications |
| yazi-binding/src/elements/renderable.rs | Adds with_area method and updates Error conversion to remove area coupling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| use super::{Bar, Border, Clear, Gauge, Line, List, Table, Text}; | ||
| use crate::{Error, elements::{Area, Rect}}; | ||
| use crate::{Error, elements::Area}; |
There was a problem hiding this comment.
The removed import Rect might still be needed elsewhere in the file. Verify that all usages of Rect have been properly addressed or replaced with Area.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3066