perf: switch to a higher-performance hash algorithm #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR switches from Rust's standard library HashMap and HashSet implementations to the hashbrown crate to improve performance. The change affects hash table usage across the entire codebase.
- Replaces
std::collections::{HashMap, HashSet}imports withhashbrown::{HashMap, HashSet} - Updates Cargo.toml files to include
hashbrownas a dependency - Removes
foldhashdependency in favor ofhashbrown
Reviewed Changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yazi-shared/src/event/data.rs | Replaces std HashMap import with hashbrown |
| yazi-shared/src/event/cmd.rs | Replaces std HashMap import with hashbrown |
| yazi-scheduler/src/prework/prework.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-scheduler/src/ongoing.rs | Replaces std HashMap import with hashbrown |
| yazi-scheduler/src/hooks.rs | Replaces std HashMap import with hashbrown |
| yazi-scheduler/Cargo.toml | Adds hashbrown dependency |
| yazi-plugin/src/loader/loader.rs | Replaces std HashMap import with hashbrown |
| yazi-plugin/Cargo.toml | Adds hashbrown dependency |
| yazi-parser/src/mgr/update_mimes.rs | Replaces std HashMap import with hashbrown |
| yazi-parser/src/app/plugin.rs | Replaces std HashMap import with hashbrown |
| yazi-fs/src/sorter.rs | Replaces std HashMap import with hashbrown |
| yazi-fs/src/op.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-fs/src/mounts/partitions.rs | Updates HashSet type annotation to use hashbrown |
| yazi-fs/src/mounts/linux.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-fs/src/fns.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-fs/src/files.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-fs/Cargo.toml | Adds hashbrown dependency |
| yazi-dds/src/state.rs | Replaces std HashMap import with hashbrown |
| yazi-dds/src/server.rs | Replaces std HashMap import with hashbrown and adds explicit type annotation |
| yazi-dds/src/sendable.rs | Replaces std HashMap import with hashbrown |
| yazi-dds/src/pubsub.rs | Consolidates HashMap and HashSet imports under hashbrown |
| yazi-dds/src/ember/hi.rs | Replaces std HashSet import with hashbrown |
| yazi-dds/src/ember/hey.rs | Replaces std HashMap import with hashbrown |
| yazi-dds/src/ember/bulk.rs | Replaces std HashMap import with hashbrown |
| yazi-dds/src/client.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-core/src/tasks/process.rs | Replaces std HashMap import with hashbrown |
| yazi-core/src/tab/finder.rs | Replaces std HashMap import with hashbrown |
| yazi-core/src/mgr/watcher.rs | Replaces std HashMap and HashSet imports with hashbrown |
| yazi-core/src/mgr/linked.rs | Replaces std HashMap import with hashbrown |
| yazi-core/src/cmp/cmp.rs | Replaces std HashMap import with hashbrown |
| yazi-config/src/theme/icon.rs | Replaces std HashMap import with hashbrown |
| yazi-config/src/plugin/plugin.rs | Replaces std HashSet import with hashbrown |
| yazi-config/src/opener/opener.rs | Replaces std HashMap import with hashbrown |
| yazi-config/src/keymap/rules.rs | Replaces std HashSet import with hashbrown |
| yazi-config/Cargo.toml | Adds hashbrown dependency |
| yazi-boot/src/boot.rs | Replaces std HashSet import with hashbrown |
| yazi-boot/Cargo.toml | Adds hashbrown dependency |
| yazi-binding/src/runtime.rs | Replaces std HashMap import with hashbrown |
| yazi-binding/src/composer.rs | Replaces foldhash HashMap with hashbrown |
| yazi-binding/Cargo.toml | Replaces foldhash dependency with hashbrown |
| yazi-actor/src/mgr/bulk_rename.rs | Replaces std HashMap import with hashbrown |
| yazi-actor/src/lives/lives.rs | Replaces foldhash HashMap with hashbrown |
| yazi-actor/src/lives/file.rs | Updates Entry import to use hashbrown |
| yazi-actor/Cargo.toml | Removes foldhash dependency, keeps existing hashbrown |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the use of Rust's standard library
HashMapandHashSet, switching tohashbrowninstead, which is around 2x faster.hashbrownalso provides some powerful features, such as theEquivalenttrait and theraw_entry()method.