fix: incorrect $0 and $@ parameters in shell command under empty directories
#3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$0 and $@ parameters in shell command under empt…$0 and $@ parameters in shell command under empty directories
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2104 (comment)
When running the
shellcommand in an empty directory, the value of$0becomes a"sh"string, and$@becomes an empty array, even if files are selected in other directories.With this PR, when in an empty directory (no hovered file),
$0will be an empty string (""), and$@will correctly contain the array of selected file paths - to fix this issue, the behavior of$0in empty directories has been changed from"sh"to"".The issue was originally introduced in 2efda75 (
$0was first supported), since then$0has never worked correctly, so this change should not break anything