fix: stricter casefold matching #3470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements stricter casefold matching to prevent ambiguous matches when multiple files have the same name in different cases. The main improvement ensures that when multiple case-insensitive matches exist, an error is returned rather than arbitrarily selecting one.
- Enhances casefold matching logic to reject ambiguous case-insensitive matches
- Adds support for handling paths that escape their base directory in URL joins
- Includes various bug fixes and improvements to task scheduling and UI rendering
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yazi-fs/src/provider/local/casefold.rs | Refactors casefold implementation to strictly match only when there's a single case-insensitive match |
| yazi-vfs/src/provider/sftp/sftp.rs | Adds stricter casefold matching for SFTP to reject multiple case-insensitive matches |
| yazi-shared/src/url/url.rs | Handles paths that escape their base directory when joining URLs for Search and Archive types |
| yazi-shared/src/path/error.rs | Adds error conversion from StartsWithError to JoinError |
| yazi-shared/src/event/cmd.rs | Improves command display formatting by separating positional and named arguments |
| yazi-scheduler/src/scheduler.rs | Fixes task completion logic to handle canceled tasks correctly |
| yazi-plugin/preset/components/progress.lua | Adds clear before rendering gauge to prevent visual artifacts |
| yazi-config/src/mgr/mgr.rs | Simplifies code by removing unnecessary UrlBuf conversion |
| yazi-config/preset/keymap-default.toml | Changes toggle behavior from wrap-around to bounded movement |
| yazi-actor/src/mgr/reveal.rs | Corrects comment wording from "on" to "over" |
| Cargo.toml | Updates serde_json dependency from 1.0.147 to 1.0.148 |
| Cargo.lock | Updates various dependencies to newer versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let mut names = vec![]; | ||
| for entry in std::fs::read_dir(parent)? { | ||
| let entry = entry?; | ||
| if let m = entry.metadata()? |
There was a problem hiding this comment.
The let pattern is missing a binding name for the metadata variable. The expression if let m = entry.metadata()? should be if let Ok(m) = entry.metadata() to properly bind the metadata result.
Suggested change
| if let m = entry.metadata()? | |
| if let Ok(m) = entry.metadata() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.