Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Elasticsearch] Add bridge #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OskarStark merged 1 commit into from
Dec 15, 2025
Merged

[Elasticsearch] Add bridge #1109

OskarStark merged 1 commit into from
Dec 15, 2025

Conversation

@llupa
Copy link
Contributor

@llupa llupa commented Dec 10, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues
License MIT

llupa
llupa commented Dec 10, 2025
View reviewed changes
@llupa llupa force-pushed the elastic-store branch 2 times, most recently from 21c2889 to a9700d5 Compare December 10, 2025 21:24
@llupa llupa marked this pull request as ready for review December 10, 2025 21:24
@carsonbot carsonbot changed the title Add ElasticSearch Store support Add ElasticSearch Store support Dec 10, 2025
@OskarStark OskarStark changed the title Add ElasticSearch Store support [Store][ElasticSearch] Add bridge Dec 11, 2025
@OskarStark
Copy link
Contributor

OskarStark commented Dec 11, 2025

Thanks for the bridge, please add the missing files like License, composer.json etc., add an example in the examples folder and update the docker compose file, thanks

@OskarStark OskarStark changed the title [Store][ElasticSearch] Add bridge [Store][Elasticsearch] Add bridge Dec 11, 2025
OskarStark
OskarStark reviewed Dec 11, 2025
View reviewed changes
@llupa
Copy link
Contributor Author

llupa commented Dec 11, 2025 •
edited
Loading

Thanks for the bridge, please add the missing files like License, composer.json etc., add an example in the examples folder and update the docker compose file, thanks

I saw the other bridges and added the files accordingly. Let me know if this is enough.

Edit: I see the failing CI, and I will update the PR later

@OskarStark
Copy link
Contributor

OskarStark commented Dec 11, 2025 •
edited
Loading

CleanShot 2025-12-11 at 14 59 54@2x

-> Elasticsearch, lowercase s

@OskarStark
Copy link
Contributor

OskarStark commented Dec 11, 2025

Please add an entry to examples/commands/store.php and update (after rebase) splitsh.json file in the root

@OskarStark
Copy link
Contributor

OskarStark commented Dec 11, 2025

To fix

------ ------------------------------------------------------------------------------------------------------------ 
  Line   rag/elasticsearch.php                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------ 
  31     Instantiated class Symfony\AI\Store\Bridge\Elasticsearch\Store not found.                                   
         🪪  class.notFound                                                                                          
         💡  Learn more at https://phpstan.org/user-guide/discovering-symbols                                        
  48     Call to method setup() on an unknown class Symfony\AI\Store\Bridge\Elasticsearch\Store.                     
         🪪  class.notFound                                                                                          
         💡  Learn more at https://phpstan.org/user-guide/discovering-symbols                                        
  53     Parameter #3 $store of class Symfony\AI\Store\Indexer constructor expects Symfony\AI\Store\StoreInterface,  
         Symfony\AI\Store\Bridge\Elasticsearch\Store given.                                                          
         🪪  argument.type                                                                                           
  56     Parameter #2 $store of class Symfony\AI\Agent\Bridge\SimilaritySearch\SimilaritySearch constructor expects  
         Symfony\AI\Store\StoreInterface, Symfony\AI\Store\Bridge\Elasticsearch\Store given.                         
         🪪  argument.type                                                                                           
 ------ ------------------------------------------------------------------------------------------------------------

you need to require your new bridge package in /examples/composer.json

@OskarStark
Copy link
Contributor

OskarStark commented Dec 12, 2025

Please upgrade phpunit:

OskarStark
OskarStark reviewed Dec 12, 2025
View reviewed changes
OskarStark
OskarStark reviewed Dec 12, 2025
View reviewed changes
@llupa llupa force-pushed the elastic-store branch 3 times, most recently from b891cef to 55cf241 Compare December 12, 2025 14:08
@carsonbot carsonbot changed the title [Store][Elasticsearch] Add bridge [Elasticsearch] Add bridge Dec 12, 2025
@llupa
Copy link
Contributor Author

llupa commented Dec 15, 2025 •
edited
Loading

small update: Until now my suspicion is that the integrations tests need a bit more safeguarding knowing when all services are healthy, ES is notorious for needing a bit extra time, so I assume having both ES and OS might result in the 403s (service not available?) that are reported in the GHA workflow.

I am going to open a PR for the GHA workflow separately and looking forward to the maintainer's input.

@OskarStark
Copy link
Contributor

OskarStark commented Dec 15, 2025

Thank you @llupa.

@OskarStark OskarStark merged commit da3c61a into symfony:main Dec 15, 2025
13 of 15 checks passed
@llupa llupa mentioned this pull request Dec 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

Assignees

No one assigned

Labels

Feature New feature Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llupa @OskarStark @carsonbot