Use become_root_cmd() when running systemd-repart in run_shell() as well #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-repart's --image switch requires root privileges as well, so let's use become_root_cmd() there as well.
behrmann
approved these changes
Jan 24, 2025
evverx
reviewed
Jan 26, 2025
| network=True, | ||
| devices=True, | ||
| options=["--bind", fname, workdir(fname)], | ||
| setup=become_root_cmd(), |
There was a problem hiding this comment.
As far as I understand the idea is to be able to run mkosi boot without sudo (and with the latest changes it works). Though it breaks when things like --register=yes/Register= are added because mkosi bails out with
Container registration requires root privilegeseven though it should have no problem with that in theory. (I'm not sure how important it is though. It's just something I noticed when I poked mkosi in the context of HACKING.md)
There was a problem hiding this comment.
It's of course possible to get it around with
mkosi boot --register=yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-repart's --image switch requires root privileges as well, so let's use become_root_cmd() there as well.