Support Swift 6.2 #38
Conversation
unxip.swift
Outdated
| } | ||
| } | ||
|
|
||
| struct MeasureFilesystemOperationAction: Sendable { |
There was a problem hiding this comment.
I feel like it's a bug that you need this at all. Nonetheless you can just make it a static function on Files rather than needing to make a structure for it.
There was a problem hiding this comment.
agreed it's a bug, I'm unsure why Swift was complaining about this. don't think it can be static because we capture the file local, but I turned it into a method on File instead.
There was a problem hiding this comment.
Ah, yes, I had profiling disabled so I didn't spot that. I think I would prefer if this was static though since it's not relevant to any other clients of File and is only used inside of Files. Can you change this to measureFilesystemOperation(named:on:operation:) (that is, adding a file parameter) and keep it local?
0f4084f to
3e98e46
Compare
|
@saagarjha i think GitHub Actions is unhappy about using secrets from the primary repo in a PR from a fork |
|
I approved the workflow so it should have access. Sorry for messing up your branch but I'll clean it up once I figure this out |
Changes are mostly standard Swift Concurrency thrash.
The one notable change is that Swift 6.2 makes metatypes non-Sendable by default (due to SE-0470 Isolated Conformances) so we need to add
SendableMetatypeconstraints… but we have to gate these behind#if swift(>=6.2)sinceSendableMetatypeisn't known to the 6.0/6.1 compiler.