Codecov Report

Merging #71 (290c896) into master (5145a08) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          139       143    +4     
=========================================
+ Hits           139       143    +4     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterpostmann please have a look and comment if you agree or not with what I have done here.

I found one more issue: We are not catching the case, where it's just the drive letter, i.e. file:///C:
Do you want to make the whole part after the colon optional? /^(?<windows_path> [A-Z]:([\/\\\\].*)?)$/x

I found one more issue: We are not catching the case, where it's just the drive letter, i.e. file:///C: Do you want to make the whole part after the colon optional? /^(?<windows_path> [A-Z]:([\/\\\\].*)?)$/x

done in 3rd commit. The new test case fails before the change and passes with the change.

IMO we are good-to-go here. @staabm reviewed the original PR previously. There has been commentary from people above that indicates they are OK with the direction this is going.

I will merge and release a patch version. That will let me move forward with PR #74 that will cause another release.

Also see discussion in issue #81 PR #25 and issue #31