Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: Address overlapping#406

Merged
mayankagnihotri7 merged 1 commit intodevelopfrom
address-overlapping
May 24, 2022
Merged

Fix: Address overlapping#406
mayankagnihotri7 merged 1 commit intodevelopfrom
address-overlapping

Conversation

@mayankagnihotri7
Copy link
Contributor

@mayankagnihotri7 mayankagnihotri7 commented May 24, 2022

Notion card

https://saeloun.notion.site/The-address-is-overlapping-on-the-next-section-on-view-invoice-page-6b8ca21f9a894486bec9bd4bd139971d

Summary

Fixed the address overlapping issue where the organization address was overlapping.

Preview

Screenshot_20220524_174241

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 24, 2022

Current Code Coverage Percent of this PR:

83.59 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 66.67 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

apoorv-mishra
apoorv-mishra approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayankagnihotri7 mayankagnihotri7 merged commit 183db6e into develop May 24, 2022
@mayankagnihotri7 mayankagnihotri7 deleted the address-overlapping branch May 24, 2022 12:44
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@mayankagnihotri7
Fix: address overlapping (#406)
2bed459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mayankagnihotri7 @apoorv-mishra