Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Organisation settings page#411

Merged
onkar-saeloun merged 68 commits intodevelopfrom
organisation-settings-page
Jun 13, 2022
Merged

Organisation settings page#411
onkar-saeloun merged 68 commits intodevelopfrom
organisation-settings-page

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented May 25, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Redesign-Organization-Settings-page-f54dbbb889424a299b3b46e37011d1e7

Summary

  • The New Org Settings page is designed.
  • Yup validations are added.
  • country and currency files are added which are reusable.
  • Logo upload, update and purge feature is integrated.

Preview

Miru._.Time.tracking.and.invoicing.-.7.June.2022.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Company name, business phone and standard rate should not be blank.
  • After selecting country, specific timezones should come in options.
  • Update button will be enabled only after changing any field.
  • Cancel should remove unsaved changes.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

sudeeptarlekar and others added 16 commits May 23, 2022 14:33
@sudeeptarlekar
Added shell UI for employee settings
f3e47a4 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added header to each page
f6e30af 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added user details in Side Nav bar
4de3b3c 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added profile edit page
136bdc9 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added shell profile react app
b4b772a 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added shell profile react app
a89d66d 
Signed-off-by: sudeeptarlekar <[email protected]>
@onkar-saeloun
added API file for organization settings page
b63125c
@onkar-saeloun
added org routes
f052c6d
@onkar-saeloun
added organization left panel
7e84cc3
@onkar-saeloun
added disabled option to header
d7242ea
@onkar-saeloun
added org billing page
556280d
@onkar-saeloun
added organization edit page
f00f9b3
@onkar-saeloun
added organization payment page
6971e94
@onkar-saeloun
added countrylist. constants
8d3521f
@onkar-saeloun
added currency list constants
21640a4
@onkar-saeloun
changed company profile page
193986e
@pr-triage pr-triage bot added the PR: draft label May 25, 2022
@onkar-saeloun onkar-saeloun self-assigned this May 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

87.64 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@onkar-saeloun onkar-saeloun requested a review from apoorv1316 June 8, 2022 09:48
@onkar-saeloun onkar-saeloun marked this pull request as ready for review June 8, 2022 09:48
@onkar-saeloun onkar-saeloun requested a review from JijoBose June 9, 2022 06:36
Base automatically changed from profile-react-app to develop June 9, 2022 09:10
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 9, 2022

@JijoBose Please review this PR.

@onkar-saeloun onkar-saeloun merged commit 26cfbc3 into develop Jun 13, 2022
@onkar-saeloun onkar-saeloun deleted the organisation-settings-page branch June 13, 2022 10:00
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun
Merge pull request #411 from saeloun/organisation-settings-page
fc4a879 
Organisation settings page merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JijoBose JijoBose JijoBose approved these changes

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

+1 more reviewer

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@onkar-saeloun onkar-saeloun

Labels

frontend PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onkar-saeloun @supriya3105 @JijoBose @sudeeptarlekar