Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Companies API#414

Merged
supriya3105 merged 18 commits intodevelopfrom
companies-api
May 30, 2022
Merged

Companies API#414
supriya3105 merged 18 commits intodevelopfrom
companies-api

Conversation

@abinashpa
Copy link
Contributor

@abinashpa abinashpa commented May 26, 2022 •
edited
Loading

Notion card

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

84.13 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@abinashpa abinashpa self-assigned this May 27, 2022
akhilgkrishnan
akhilgkrishnan reviewed May 27, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abinashpa Added some comments

@abinashpa abinashpa requested a review from akhilgkrishnan May 30, 2022 04:58
@supriya3105 supriya3105 merged commit 0bc2912 into develop May 30, 2022
@supriya3105 supriya3105 deleted the companies-api branch May 30, 2022 07:12
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@akhilgkrishnan
Companies API (#414)
ffa09f1 
* Create MIT License

* client index spec, match_array added

* employee dropdown added

* replace current_workplace with current_company in time_tracking_controller.rb

* fetch entries issue fixes

* admin's crud operation added

* useEffect for selectedEmployeeId added

* timesheet entry rspec fixes

* companies api added

* companies api rspec added

* defination name updated for company test

* negative test case added

* gems updated on Company API

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees

@abinashpa abinashpa

Labels

backend PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abinashpa @apoorv1316 @akhilgkrishnan @supriya3105