Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BugFix]Create customer for connected account instead of platform#415

Merged
apoorv-mishra merged 3 commits intodevelopfrom
fix-stripe-invalid-customer
May 26, 2022
Merged

[BugFix]Create customer for connected account instead of platform#415
apoorv-mishra merged 3 commits intodevelopfrom
fix-stripe-invalid-customer

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented May 26, 2022

Notion card

NA

Summary

Fix to create customer for connected account instead of the platform. Refer docs for the right ways to make API calls for connected accounts.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

83.86 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

akhilgkrishnan
akhilgkrishnan reviewed May 26, 2022
View reviewed changes
@apoorv1316 apoorv1316 self-requested a review May 26, 2022 07:21
apoorv1316
apoorv1316 approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and payment was successful in local

shivamsinghchahar
shivamsinghchahar approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@shivamsinghchahar shivamsinghchahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apoorv-mishra Nice catch! LGTM

@apoorv-mishra apoorv-mishra merged commit f23568e into develop May 26, 2022
@apoorv-mishra apoorv-mishra deleted the fix-stripe-invalid-customer branch May 26, 2022 10:35
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
[BugFix]Create customer for connected account instead of platform (#415)
841db62 
* Fix to create customer for connected account instead of platform

* Add specs for method

* Fix failing spec in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan left review comments

@apoorv1316 apoorv1316 apoorv1316 approved these changes

+1 more reviewer

@shivamsinghchahar shivamsinghchahar shivamsinghchahar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apoorv-mishra @shivamsinghchahar @apoorv1316 @akhilgkrishnan