Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement delete on show invoice page#416

Merged
supriya3105 merged 1 commit intodevelopfrom
implement-delete-on-invoice-show
May 26, 2022
Merged

Implement delete on show invoice page#416
supriya3105 merged 1 commit intodevelopfrom
implement-delete-on-invoice-show

Conversation

@apoorv1316
Copy link
Collaborator

@apoorv1316 apoorv1316 commented May 26, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=185bd45b9dc24dfcad9c57c07d32a7c0&p=0462765fa544450faf24753843c6e7bf

Preview

https://www.loom.com/share/1fbfe3128d1f4550ad1076d0286e97fa

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@apoorv1316 apoorv1316 requested a review from supriya3105 May 26, 2022 06:58
@github-actions
Copy link

github-actions bot commented May 26, 2022

Current Code Coverage Percent of this PR:

83.53 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 66.67 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@supriya3105 supriya3105 merged commit 7e16663 into develop May 26, 2022
@supriya3105 supriya3105 deleted the implement-delete-on-invoice-show branch May 26, 2022 09:47
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@apoorv1316
implement delete on show invoice page (#416)
8012a5e 
Co-authored-by: “Apoorv <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apoorv1316 @supriya3105