Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor specs#417

Merged
supriya3105 merged 2 commits intodevelopfrom
refactor-specs
May 26, 2022
Merged

Refactor specs#417
supriya3105 merged 2 commits intodevelopfrom
refactor-specs

Conversation

@sudeeptarlekar
Copy link
Contributor

Notion card

NA

Summary

Refactored specs

Type of change

  • Refactored code.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

Signed-off-by: sudeeptarlekar <[email protected]>
Signed-off-by: sudeeptarlekar <[email protected]>
@github-actions
Copy link

Current Code Coverage Percent of this PR:

83.59 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

}]
expect(company.client_list).to eq(result)
expect(company.client_list).to match_array [
a_hash_including(id: client_1.id),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.


require "rails_helper"

shared_examples_for "InternalApi::V1::Projects#index project list" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@supriya3105 supriya3105 merged commit 741f832 into develop May 26, 2022
@supriya3105 supriya3105 deleted the refactor-specs branch May 26, 2022 10:53
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* Refactored project index specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Refactored company specs

Signed-off-by: sudeeptarlekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants