Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate user details before inviting#420

Merged
apoorv1316 merged 2 commits intodevelopfrom
last-name-mandatory-team-invite
May 30, 2022
Merged

Validate user details before inviting#420
apoorv1316 merged 2 commits intodevelopfrom
last-name-mandatory-team-invite

Conversation

@apoorv1316
Copy link
Collaborator

@apoorv1316 apoorv1316 commented May 27, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=185bd45b9dc24dfcad9c57c07d32a7c0&p=8986924f16fd43ec80ba31ef2672f005

Summary

Validate the presence of first_name, last_name, and email before sending an invite to a user.

Preview

https://www.loom.com/share/779e6af4fe7a4a9a87197d5399340ee7

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 30, 2022

Current Code Coverage Percent of this PR:

83.86 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

apoorv-mishra
apoorv-mishra approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apoorv1316 apoorv1316 merged commit c1fc701 into develop May 30, 2022
@apoorv1316 apoorv1316 deleted the last-name-mandatory-team-invite branch May 30, 2022 06:12
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@apoorv1316
Validate user details before inviting (#420)
abd48e5 
* validate-user-before-inviting

* fix failing tests

Co-authored-by: “Apoorv <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apoorv1316 @apoorv-mishra @supriya3105