Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rails toast redesign#421

Merged
supriya3105 merged 4 commits intodevelopfrom
rails-toaster
Jun 1, 2022
Merged

Rails toast redesign#421
supriya3105 merged 4 commits intodevelopfrom
rails-toaster

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented May 30, 2022

Notion card

https://www.notion.so/saeloun/Toast-message-in-React-and-rails-should-be-same-b70c5924a7454544bafbda6e1c564a08

Summary

Redesigned the rails toast notification to match react toast design.

Preview

https://www.loom.com/share/0fd6fcaed9624ceebc97e98e4e05a15f

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

akhilgkrishnan
akhilgkrishnan reviewed May 30, 2022
View reviewed changes
@supriya3105
Copy link
Contributor

supriya3105 commented May 30, 2022

@gowsik-ragunath CI tests are failing on this PR. Please fix it.

@github-actions
Copy link

github-actions bot commented May 31, 2022

Current Code Coverage Percent of this PR:

84.16 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented May 31, 2022

@supriya3105 CI tests are passing now.

@supriya3105 supriya3105 merged commit 43d75bc into develop Jun 1, 2022
@supriya3105 supriya3105 deleted the rails-toaster branch June 1, 2022 04:58
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Rails toast redesign (#421)
57e6d52 
* Redesigned rails toaster and added custom icon

* Fixed the issue in positioning close button in rails toaster message

* Moved toast related css styling to taost.scss

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan left review comments

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

@AkashKale AkashKale Awaiting requested review from AkashKale

@supriya3105 supriya3105 Awaiting requested review from supriya3105

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gowsik-ragunath @supriya3105 @apoorv1316 @akhilgkrishnan