An external user should not be able to modify invoice URL to view any invoice in Miru. #422
Merged
aniketkaushik merged 14 commits intodevelopfrom Jun 14, 2022
Merged
Conversation
c6ed8b9 to
0bfeda1
Compare
Current Code Coverage Percent of this PR:88.12 %Files having coverage below 100%
|
Contributor
|
@aniket-k-kaushik Please resolve the conflicts . @apoorv-mishra @akhilgkrishnan Please review the PR. |
a99e6e5 to
d35fa04
Compare
apoorv-mishra
suggested changes
Jun 2, 2022
fc5d26c to
952e5a2
Compare
apoorv-mishra
suggested changes
Jun 3, 2022
|
|
||
| class AddExternalViewKeyToInvoice < ActiveRecord::Migration[7.0] | ||
| def change | ||
| add_column :invoices, :external_view_key, :string |
Contributor
There was a problem hiding this comment.
Better to add a unique constraint for external_view_key as well. Refer this
apoorv-mishra
suggested changes
Jun 3, 2022
244babd to
de2171c
Compare
Contributor
|
@apoorv1316 Can you get this tested on someone else's system today. |
added 14 commits
June 12, 2022 00:54
391c210 to
c65d146
Compare
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
This looks good but we could potentially use UUID which is more conventional way of achieving the same https://pawelurbanek.com/uuid-order-rails @aniket-k-kaushik @apoorv-mishra @akhilgkrishnan @sudeeptarlekar
Contributor
|
@apoorv1316 Can you coordinate this with Aniket and Anas and make sure we are closing this today. |
apoorv1316
approved these changes
Jun 14, 2022
Collaborator
|
@supriya3105 I have approved it. |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
… invoice in Miru. (#422) * added external random key to accsess view * added uniqueness * seed update * minor update * fix * fix * securerandom * test fix * path fix * test fix * test fix 2 * add uniqueness external_view_key * added uniques true to migration * test fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://saeloun.notion.site/An-external-user-should-not-be-able-to-modify-invoice-URL-to-view-any-invoice-in-Miru-940481f83c804debbc448855a759a673
Checklist: