Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Purge Companies Logo API#428

Merged
abinashpa merged 24 commits intodevelopfrom
purge-logo-api
Jun 1, 2022
Merged

Purge Companies Logo API#428
abinashpa merged 24 commits intodevelopfrom
purge-logo-api

Conversation

@abinashpa
Copy link
Contributor

@abinashpa abinashpa commented May 31, 2022 •
edited
Loading

Notion card

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

akhilgkrishnan and others added 20 commits May 10, 2022 14:27
@akhilgkrishnan
Create MIT License
5c99eb1
client index spec, match_array added
d727381
Merge branch 'develop' of https://github.com/saeloun/miru-web into ad…
f354668 
…d-license-1-test-patch
employee dropdown added
c89a3d8
Merge branch 'develop' of https://github.com/saeloun/miru-web into em…
e614b7c 
…ployee-dropdown
replace current_workplace with current_company in time_tracking_contr…
ae6db92 
…oller.rb
fetch entries issue fixes
7e8b729
admin's crud operation added
6b5393c
useEffect for selectedEmployeeId added
ee06d55
timesheet entry rspec fixes
6bde2ab
companies api added
c390720
Merge branch 'develop' of https://github.com/saeloun/miru-web into co…
7f6439a 
…mpanies-api
companies api rspec added
6630fc1
defination name updated for company test
d7ad794
negative test case added
8275635
@akhilgkrishnan
Merge branch 'develop' into companies-api
365b256
gems updated on Company API
d78766a
Merge branch 'companies-api' of https://github.com/saeloun/miru-web i…
b0f4933 
…nto companies-api
Merge branch 'develop' of https://github.com/saeloun/miru-web into co…
ea2612d 
…mpanies-api
purge logo api added
cbe531e
@abinashpa abinashpa self-assigned this May 31, 2022
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

84.24 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

akhilgkrishnan
akhilgkrishnan reviewed Jun 1, 2022
View reviewed changes
apoorv1316
apoorv1316 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a failing condition test

@abinashpa abinashpa requested a review from akhilgkrishnan June 1, 2022 09:22
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 1, 2022

@abinashpa The CI checks are still failing. Please check . Shalaka has fixed the reports related tests that were failing earlier.

@abinashpa abinashpa merged commit ebab3ba into develop Jun 1, 2022
@abinashpa abinashpa deleted the purge-logo-api branch June 1, 2022 12:00
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Merge pull request #428 from saeloun/purge-logo-api
6746a5f 
Purge Companies Logo API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees

@abinashpa abinashpa

Labels

backend PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abinashpa @supriya3105 @apoorv1316 @akhilgkrishnan